Exclude paginated pages in sitemap #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranitbauva1997
changed the title
Keats
requested changes
Jul 1, 2024
|
@Keats Can you please re-review this? |
|
@Keats Made the required changes of using a string value instead of boolean so that we can further expand the scope by including other options. Can you please re-review? |
Keats
requested changes
Aug 21, 2024
This fixes #2527.
|
@Keats Made the changes and tested them on my website. Earlier wrong values weren't throwing errors. Now, they are throwing descriptive errors. |
|
@Keats thanks for approving the PR. This is my first contribution over here, so what would be the next steps? Please let me know if there is anything to be done from my side. |
|
Nothing, that's all good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2527. @Keats, Can you please have a look at this and suggest improvements?
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one: