Move sublime into config module #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's fine? I can't think of issues caused by that. |
Having a crate depend on files outside of its directory breaks building Zola as a dependency using Nix
|
I don't think there are any issues caused by this change, it's more like a matter of aesthetics 🙂 If you don't object, maybe let's get it merged? |
|
Yep sorry forgot about it |
|
Thank you! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is maybe a bit of controversial change, but I stumbled upon inability to build my crate (which depends on some parts of Zola) using Nix. The problem is that Nix builds every crate in an isolated environment, but since the
configcomponent depends on sublime files outside its crate root, the build fails.I discussed the issue with a person who maintains the rust harness for Nix, and he suggested fixing it in Zola: ipetkov/crane#666 (comment)
There's a bit more info attached there.
Hope you will consider these changes 😊
It would also make publishing Zola's subcrates to crates.io a bit more feasible.
Sanity check:
nextbranch?