Add optional arg to serve for extra paths to watch for changes
#2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparrett
changed the title
serve for extra paths to watch for changes
Keats
requested changes
Dec 23, 2024
|
|
||
| /// Extra path to watch for changes, relative to the project root. | ||
| #[clap(long)] | ||
| extra_watch_path: Vec<String>, |
There was a problem hiding this comment.
Should it be extra_watch_paths since it's a vec?
There was a problem hiding this comment.
It's a vec, but the user would multiple paths by repeating the argument.
zola serve --extra_watch_path="a" --extra_watch_path="b"So I think the singular makes the most sense. There's some precedent for this, e.g.
curl --header "Content-Type: application/json" --header "Authorization: Bearer token" https://api.example.com
grep --regexp="pattern1" --regexp="pattern2" file.txtHappy to change it if you prefer though.
There was a problem hiding this comment.
That's fine, I thought it was --extra_watch_paths=something,something_else with clap being smart enough to split on the ,
Keats
approved these changes
Dec 25, 2024
|
|
||
| /// Extra path to watch for changes, relative to the project root. | ||
| #[clap(long)] | ||
| extra_watch_path: Vec<String>, |
There was a problem hiding this comment.
That's fine, I thought it was --extra_watch_paths=something,something_else with clap being smart enough to split on the ,
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a feature discussed in #2741.
Sanity check:
Code changes
Are you doing the PR on the
nextbranch?Have you created/updated the relevant documentation page(s)?
There does seem to be some existing documentation related to the args for
serve, but it is not comprehensive, and I suspect this isn't important enough to include there.