Skip to content
This repository has been archived by the owner on Jan 7, 2025. It is now read-only.

Commit

Permalink
Pin astroid version to fix pylint recursion error
Browse files Browse the repository at this point in the history
This fixes a problem we've encountered where pylint tests fail with
this error:

	RecursionError: maximum recursion depth exceeded in comparison

The bug appears to be this one:

	pylint-dev/pylint#3318

For the record, this was extremely hard to track down.  The error
appeared erratically, as there appears to be some caching (and
invalidation + recreation) of tox environments and/or packages that
feeds into this.

We can revisit the version pinning in the future; at the moment,
there's no other motivation for the pinning.

Signed-off-by: Hugh Brown (Saint Aardvark the Carpeted) <aardvark@saintaardvarkthecarpeted.com>
  • Loading branch information
saintaardvark committed Jan 15, 2020
1 parent 2a40b99 commit cf133ad
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ envlist = flake8,isort,yapf,pylint,build,pytest
flake8 = 3.7.7
isort = 4.3.21
yapf = 0.27.0
astroid = 2.2.5
pylint = 2.3.1
pytest = 4.4.2
pytest-cov = 2.7.1
Expand Down Expand Up @@ -53,6 +54,7 @@ commands = pytest -v --cov=polaris --cov=contrib tests
deps =
pylint=={[depversions]pylint}
pytest=={[depversions]pytest}
astroid=={[depversions]astroid}
commands = pylint \
tests \
{envsitepackagesdir}/polaris \
Expand Down

0 comments on commit cf133ad

Please sign in to comment.