Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test hang on 3.9.8+ and upcoming 3.10+ #1839

Closed
jamadden opened this issue Dec 3, 2021 · 0 comments
Closed

Test hang on 3.9.8+ and upcoming 3.10+ #1839

jamadden opened this issue Dec 3, 2021 · 0 comments

Comments

@jamadden
Copy link
Member

jamadden commented Dec 3, 2021

From #1828 (comment) :

The manifestation in the test suite is that the test that monkey-patches from a non-main thread hangs on 3.9.8 and above when the interpreter tries to exit; you have to kill it with ctrl-C.

$ python -u -mgevent.tests.test__threading_monkey_in_thread
.
----------------------------------------------------------------------
Ran 1 test in 0.236s

OK
^CException ignored in: <module 'threading' from '//3.9/lib/python3.9/threading.py'>
Traceback (most recent call last):
  File "//3.9/lib/python3.9/threading.py", line 1470, in _shutdown
    lock.acquire()
KeyboardInterrupt:

In the past, gevent has had to special-case some things around this, in part to workaround the bug that just got fixed in CPython. But just disabling that workaround doesn't fix the test.

This is probably caused by https://bugs.python.org/issue1596321 (3.9 "fix" is python/cpython#28589, 3.10 is python/cpython#28588)

jamadden added a commit that referenced this issue Dec 7, 2021
There is probably a more elegant solution.
jamadden added a commit that referenced this issue Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant