fix(ecy): configuration file path changed #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using eza instead of exa ogham/exa#1243
gforien
pushed a commit
that referenced
this pull request
Oct 25, 2024
Bug: given only 1 IP in the SG, 1 is revoked, 1 is authorized Given one IP in the SG '92.143.36.217' Run `gf aws inboundIp` Result: the SG now contains one IP '2a01:cb14:1686::' Expected result: the SG contains both IPs '2a01:cb14:1686::', and '92.143.36.217' Why ? - IPv4 is skipped, because it belongs to the SG - IPv6 is added to the group - all rules are revoked - the group is authorized Fix #1: Revoke and authorize the whole group. But now the group is revoked+authorized even to the identical Fix #2: Add comparison methods for []IpRange []Ipv6Range []IpPermission Add tests
gforien
pushed a commit
that referenced
this pull request
Oct 25, 2024
Bug: given only 1 IP in the SG, 1 is revoked, 1 is authorized Given one IP in the SG '92.143.36.217' Run `gf aws inboundIp` Result: the SG now contains one IP '2a01:cb14:1686::' Expected result: the SG contains both IPs '2a01:cb14:1686::', and '92.143.36.217' Why ? - IPv4 is skipped, because it belongs to the SG - IPv6 is added to the group - all rules are revoked - the group is authorized Fix #1: Revoke and authorize the whole group. But now the group is revoked+authorized even to the identical Fix #2: Add comparison methods for []IpRange []Ipv6Range []IpPermission Remove methods Ip.ToAwsIpPerms() and Ip.ExistsInAwsSg() Add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using eza instead of exa
ogham/exa#1243