Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows GNU toolchain in AppVeyor #1007

Closed
kvark opened this issue Jul 29, 2016 · 1 comment
Closed

Fix Windows GNU toolchain in AppVeyor #1007

kvark opened this issue Jul 29, 2016 · 1 comment
Labels
difficulty: easy type: bug value: low

Comments

@kvark
Copy link
Member

kvark commented Jul 29, 2016

Currently failing to download Mingw
@kvark
Copy link
Member Author

kvark commented Aug 12, 2016

Fixed by #983

@kvark kvark closed this as completed Aug 12, 2016
adamnemecek pushed a commit to adamnemecek/gfx that referenced this issue Apr 1, 2021
@bors @cwfitzgerald
Merge gfx-rs#1007
c6c50e9 
1007: Improve cubemap validation r=kvark a=cwfitzgerald

**Connections**

Closes gfx-rs#952.

**Description**

We were missing depth-size and texture dimension validation when creating Cubemap and CubemapArray views.

I split the depth-size errors so I can give a more helpful error message in both cases.

**Testing**

Tested on the skybox example when made intensionally incorrect.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy type: bug value: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kvark