Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API Design] [II] Get rid of unnamed parameters in traits #1829

Closed
mjadczak opened this issue Feb 17, 2018 · 1 comment
Closed

[API Design] [II] Get rid of unnamed parameters in traits #1829

mjadczak opened this issue Feb 17, 2018 · 1 comment

Comments

@mjadczak
Copy link
Contributor

Rust RFC 1685 deprecates anonymous parameters in trait functions. These functions use anonymous parameters and descriptive parameter names should be added:

  • gfx_hal::adapter::PhysicalDevice
    • open
    • format_properties
  • gfx_hal::queue::capability::Capability
    • supported_by
  • gfx_backend_dx11::command::Parser
    • parse
    • update_buffer
    • update_texture
  • gfx_hal::device::Device
    • free_memory
    • create_command_pool
    • destroy_command_pool
    • destroy_renderpass
    • destroy_pipeline_layout
    • destroy_graphics_pipeline
    • destroy_compute_pipeline
    • destroy_framebuffer
    • destroy_shader_module
    • create_buffer
    • get_buffer_requirements
    • bind_buffer_memory
    • destroy_buffer
    • create_buffer_view
    • destroy_buffer_view
    • create_image
    • get_image_requirements
    • bind_image_memory
    • destroy_image
    • create_image_view
    • destroy_image_view
    • create_sampler
    • destroy_sampler
    • destroy_descriptor_pool
    • destroy_descriptor_set_layout
    • write_descriptor_sets
    • copy_descriptor_sets
    • map_memory
    • flush_mapped_memory_ranges
    • invalidate_mapped_memory_ranges
    • unmap_memory
    • destroy_semaphore
    • get_fence_status
    • destroy_fence
    • create_query_pool
    • destroy_query_pool
  • gfx_hal::queue:RawCommandQueue
    • submit_raw
  • gfx_hal::window::Surface
    • supports_queue_family
    • capabilities_and_formats
@mjadczak mjadczak changed the title [II] Get rid of unnamed parameters in traits [API Design] [II] Get rid of unnamed parameters in traits Feb 17, 2018
@kvark
Copy link
Member

kvark commented Feb 18, 2018

Uh, I really liked this feature. But yeah, let's do it.

@kichristensen kichristensen mentioned this issue Apr 2, 2018
Merged
3 tasks
bors bot added a commit that referenced this issue Apr 3, 2018
@bors
Merge #1902
211613c 
1902: Remove unnamed parameters in traits r=kvark a=kichristensen

Fixes #1829 

PR checklist:
- [ ] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [ ] tested examples with the following backends:
@bors bors bot closed this as completed in #1902 Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @mjadczak