Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Device completely self-contained with associated types #416

Closed
emberian opened this issue Nov 3, 2014 · 0 comments · Fixed by #597
Closed

Make Device completely self-contained with associated types #416

emberian opened this issue Nov 3, 2014 · 0 comments · Fixed by #597
Assignees
@brendanzab
Labels
difficulty: average module: hal status: blocked type: refactor value: strategic

Comments

@emberian
Copy link
Contributor

emberian commented Nov 3, 2014

This will be required for supporting multiple-backends. Blocked on rust-lang/rust#17307
@emberian emberian mentioned this issue Nov 6, 2014
Closed
@sectopod sectopod mentioned this issue Feb 3, 2015
Closed
8 tasks
This was referenced Feb 14, 2015
Closed
Closed
Merged
@kvark kvark assigned brendanzab and unassigned sectopod Feb 18, 2015
This was referenced Feb 22, 2015
Merged
Merged
Merged
Merged
Merged
adamnemecek pushed a commit to adamnemecek/gfx that referenced this issue Apr 1, 2021
@bors @Korijn
@fintelia @Veykril
Merge gfx-rs#416 gfx-rs#420 gfx-rs#424
890bbcf 
416: Makefile package command and travis github releases r=kvark a=Korijn

Closes gfx-rs#414

Approach mostly mimicked from [gfx-portability](https://github.com/gfx-rs/portability) as recommended to me by @kvark. I needed a number of commits to iron out some kinks for the Windows builds, so I would recommend using squash merge when accepting this PR.

Note that the Windows rust=nightly build fails, but it's also broken on master, so it's unrelated to the changes in this PR.

/cc @almarklein

# Questions

- [x] Would it make sense to also regenerate the `ffi/wgpu.h` and `wgpu-remote.h` header files and include them in the zip archive?

# Todo for maintainers

- [x] Configure encrypted `api_key`
As in [gfx-portability](https://github.com/gfx-rs/portability/blob/master/.travis.yml#L61) you will need to create an API key and commit it to the `.travis.yml` file. I've checked "allow edits from maintainers" so you should be able to commit to this branch directly. You may want to reference the [Travis instructions](https://docs.travis-ci.com/user/deployment/releases/#authenticating-with-an-oauth-token) as well.

- [ ] Tag revisions
Previous versions (`v0.1` - `v0.4`) have not been tagged on the master branch, you will want to do so retroactively. Also, when releasing in the future, make sure to tag the commit before pushing. Alternatively, you can schedule a travis build manually after applying the tag retroactively.

420: Make Origin3d::{x,y,z} all have type u32 r=kvark a=fintelia

Fixes gfx-rs#419 

424: swapchain creation: check if selected present mode is supported r=kvark a=Veykril

Implements a simple check as talked about in gfx-rs#350 to fallback to `FIFO` should the selected present mode not be available on the system.

Co-authored-by: Korijn van Golen <k.vangolen@clinicalgraphics.com>
Co-authored-by: Korijn van Golen <korijn@gmail.com>
Co-authored-by: Jonathan Behrens <fintelia@gmail.com>
Co-authored-by: Veykril <lukastw97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brendanzab brendanzab

Labels
difficulty: average module: hal status: blocked type: refactor value: strategic
Projects
None yet
Milestone
No milestone
4 participants
@kvark @brendanzab @emberian @sectopod