Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic depth output handling #986

Merged
merged 2 commits into from
Jun 2, 2016
Merged

Basic depth output handling #986

merged 2 commits into from
Jun 2, 2016

Conversation

sectopod
Copy link
Contributor

@sectopod sectopod commented Jun 2, 2016

Fixes #984

@sectopod
Copy link
Contributor Author

sectopod commented Jun 2, 2016

There is a question of how we are going to publish it. Technically, the ProgramInfo struct is public. But we don't expect anyone to actually use it directly, other than our graphics backends. So I suggest bumping the patch version for the release.

@kvark
Copy link
Member

kvark commented Jun 2, 2016

Looks like we are green, merging.
@homu r+

@homu
Copy link
Contributor

homu commented Jun 2, 2016

📌 Commit fc81cf3 has been approved by kvark

@homu homu merged commit fc81cf3 into gfx-rs:master Jun 2, 2016
homu added a commit that referenced this pull request Jun 2, 2016
@homu
Auto merge of #986 - sectopod:depth, r=kvark
86bbe5d 
Basic depth output handling

Fixes #984
@homu
Copy link
Contributor

homu commented Jun 2, 2016

⚡ Test exempted - status

adamnemecek pushed a commit to adamnemecek/gfx that referenced this pull request Apr 1, 2021
@bors @kvark
Merge gfx-rs#987
3c801ee 
987: Align stencil reference flags between pipeline creation and setting r=cwfitzgerald a=kvark

Sibling of gfx-rs#986 for master

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sectopod @kvark @homu