Adding support for the raytracing. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases the foreign-type version, Adds a new example for showing raytracing capabilities in metal 3. CI action version increase code improvement in foreign_obj_type macro. And adding several other needed features in the code.
kvark
reviewed
Dec 26, 2022
There was a problem hiding this comment.
This is amazing work ❤️ , and a great present for New Year / Christmas to the community!
I was just thinking about how it would be required for metal-rs to get the RT support before we can get anywhere with a portable RT API/implementation, and your PR couldn't be timed more perfectly.
My only concern is how this giant change got unnecessarily more giant by including the foreign types update (long-needed!). Ideally, the foreign-types would be updated in a separate commit (or a PR). I don't consider this a blocker, though.
Let's just resolve the few notes raised and proceed (squashed).
Hossein-Noroozpour
force-pushed
the
master
branch
from
9f7ec50 to
3301cbd
Compare
…ent change in the API
kvark
approved these changes
Dec 27, 2022
|
Let's proceed when you are ready. |
|
It's ready! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.