Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_null() helper function to Texture #253

Closed
wants to merge 1 commit into from
Closed

Add is_null() helper function to Texture #253

wants to merge 1 commit into from

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Jan 16, 2023 •
edited
Loading

Avoid adding direct dependencies of the foreign_types crate in wgpu to determine if the Texture is NULL.

wgpu issue: gfx-rs/wgpu#3153

kvark
kvark reviewed Mar 3, 2023
View reviewed changes
src/texture.rs Show resolved Hide resolved
@jinleili
Copy link
Contributor Author

jinleili commented Mar 3, 2023

Sorry, since foreign_types crate has been introduced as a dependency of wgpu, there is no longer any reason to add this function.

@jinleili jinleili closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinleili @kvark