Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Metal timestamps #263

Merged
merged 16 commits into from
Apr 1, 2023
Merged

feature: Metal timestamps #263

merged 16 commits into from
Apr 1, 2023

Conversation

FL33TW00D
Copy link
Contributor

@FL33TW00D FL33TW00D commented Mar 29, 2023 •
edited
Loading

This is required for wgpu to ship timestamp queries on Metal.

Related Issue: gfx-rs/wgpu#2739

  • add functionality to render passes.
  • resolve to actual time instead of internal time.
  • correctly fetch and extract timestamp counterset from counterset array.

kvark
kvark reviewed Mar 29, 2023
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

examples/counters/main.rs Outdated Show resolved Hide resolved
src/device.rs Show resolved Hide resolved
FL33TW00D
FL33TW00D commented Mar 29, 2023
View reviewed changes
examples/counters/main.rs Outdated Show resolved Hide resolved
FL33TW00D
FL33TW00D commented Mar 30, 2023
View reviewed changes
examples/counters/main.rs Outdated Show resolved Hide resolved
@FL33TW00D FL33TW00D marked this pull request as ready for review March 30, 2023 20:32
@FL33TW00D
Copy link
Contributor Author

FL33TW00D commented Mar 31, 2023 •
edited
Loading

@kvark Ready to go now (when you have time 🙇🏻 ) - I fixed the segfault and merged the compute and counters example.

@kvark kvark enabled auto-merge (squash) April 1, 2023 05:43
@kvark kvark merged commit b04fec3 into gfx-rs:master Apr 1, 2023
@FL33TW00D FL33TW00D mentioned this pull request Apr 2, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FL33TW00D @kvark