Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make the features testable and threadsafe. #290

Closed
wants to merge 19 commits into from
Closed

feat: Make the features testable and threadsafe. #290

wants to merge 19 commits into from

Commits on Oct 18, 2023

  1. Initial matrix multiplication support. Still some bugs to iron out bu… 

    …t works
    @ivarflakstad
    ivarflakstad committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    09c5333 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Remove over the top abstractions. Changed test to example

    @ivarflakstad
    ivarflakstad committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    4f4df06 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Use "apply" scheme for gemm function. Buffer reading bug needs fix.

    @ivarflakstad
    ivarflakstad committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    530e2c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Matrix multiplication example is now a performance test. Seems to wor… 

    …k except GFLOPS calculation
    @ivarflakstad
    ivarflakstad committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    5cd97c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Add gemm correctness test and improve the performance test

    @ivarflakstad
    ivarflakstad committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    aed9b29 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. small improvements

    @ivarflakstad
    ivarflakstad committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2c1490c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'gfx-rs:master' into mps-matrix-multiplication-kernel

    @ivarflakstad
    ivarflakstad authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    313a768 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Merge pull request #1 from ivarflakstad/mps-matrix-multiplication-kernel 

    Mps matrix multiplication kernel
    @ivarflakstad
    ivarflakstad authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c130b1c View commit details
    Browse the repository at this point in the history

  2. wait_until_completed() outside of inner loop

    @ivarflakstad
    ivarflakstad committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    7791312 View commit details
    Browse the repository at this point in the history

  3. Easier to change matrix types in gemm benchmark

    @ivarflakstad
    ivarflakstad committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    933b3b8 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2 from ivarflakstad/mps-improve-gemm-benchmark 

    Improve gemm benchmark

Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>
    @ivarflakstad @Narsil
    ivarflakstad and Narsil authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c667fc4 View commit details
    Browse the repository at this point in the history

  5. Ditch generic Matrix and use MatrixBuffer instead. Create buffers sep… 

    …arately of encoding.
    @ivarflakstad
    ivarflakstad committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    36ae080 View commit details
    Browse the repository at this point in the history

  6. Mark encode_gemm c parameter as &mut

    @ivarflakstad
    ivarflakstad committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    7910f10 View commit details
    Browse the repository at this point in the history

  7. Return Result from encode_gemm

    @ivarflakstad
    ivarflakstad committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    aaf2647 View commit details
    Browse the repository at this point in the history

  8. MPSDataType TYPE_ID -> u32

    @ivarflakstad
    ivarflakstad committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    ad60768 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #3 from ivarflakstad/mps-gemm-matrixbuffer-improve… 

    …ments

Use MatrixBuffers for encode_gemm. Do not create result buffer within.
    @ivarflakstad
    ivarflakstad authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3864ca7 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into mpsdatatype-should-be-u32

    @ivarflakstad
    ivarflakstad committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    a2aff24 View commit details
    Browse the repository at this point in the history

  11. Merge pull request #4 from ivarflakstad/mpsdatatype-should-be-u32 

    Mpsdatatype should be u32
    @ivarflakstad
    ivarflakstad authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3a4bd86 View commit details
    Browse the repository at this point in the history

  12. feat: Make the features testable and threadsafe. 

    tl;dr. No idea why we need this, but if we don't the main thread
will attempt to release the `MatrixDescriptor` and fail.

This fix is a dirty hack which simply leaks those `MatrixDescriptor`.
Which *seems* ok since they get cleaned up by the releasepool at the end of
the program, but this is definitely a temporary workaround, which should
at least enable adding a few tests on the test suite.
    @Narsil
    Narsil committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    5a66ce1 View commit details
    Browse the repository at this point in the history