Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanup #291

Closed
wants to merge 20 commits into from
Closed

Some cleanup #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
09c5333
Initial matrix multiplication support. Still some bugs to iron out bu…
ivarflakstad Oct 18, 2023
4f4df06
Remove over the top abstractions. Changed test to example
ivarflakstad Oct 20, 2023
530e2c1
Use "apply" scheme for gemm function. Buffer reading bug needs fix.
ivarflakstad Oct 21, 2023
5cd97c3
Matrix multiplication example is now a performance test. Seems to wor…
ivarflakstad Oct 25, 2023
aed9b29
Add gemm correctness test and improve the performance test
ivarflakstad Oct 26, 2023
2c1490c
small improvements
ivarflakstad Oct 30, 2023
313a768
Merge branch 'gfx-rs:master' into mps-matrix-multiplication-kernel
ivarflakstad Oct 30, 2023
c130b1c
Merge pull request #1 from ivarflakstad/mps-matrix-multiplication-kernel
ivarflakstad Oct 31, 2023
7791312
wait_until_completed() outside of inner loop
ivarflakstad Oct 31, 2023
933b3b8
Easier to change matrix types in gemm benchmark
ivarflakstad Oct 31, 2023
c667fc4
Merge pull request #2 from ivarflakstad/mps-improve-gemm-benchmark
ivarflakstad Oct 31, 2023
36ae080
Ditch generic Matrix and use MatrixBuffer instead. Create buffers sep…
ivarflakstad Oct 31, 2023
7910f10
Mark encode_gemm c parameter as &mut
ivarflakstad Oct 31, 2023
aaf2647
Return Result from encode_gemm
ivarflakstad Oct 31, 2023
ad60768
MPSDataType TYPE_ID -> u32
ivarflakstad Oct 31, 2023
3864ca7
Merge pull request #3 from ivarflakstad/mps-gemm-matrixbuffer-improve…
ivarflakstad Oct 31, 2023
a2aff24
Merge branch 'master' into mpsdatatype-should-be-u32
ivarflakstad Oct 31, 2023
3a4bd86
Merge pull request #4 from ivarflakstad/mpsdatatype-should-be-u32
ivarflakstad Oct 31, 2023
5a66ce1
feat: Make the features testable and threadsafe.
Narsil Oct 31, 2023
bc755b4
Some cleanup.
Narsil Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ block = "0.1.6"
foreign-types = "0.5"
dispatch = { version = "0.2", optional = true }
paste = "1"
half = "2.3.1"

[dependencies.objc]
version = "0.2.4"
Expand Down Expand Up @@ -76,7 +77,18 @@ name = "compute"
path = "examples/compute/main.rs"

[[example]]
name = "mps"
name = "mps-matrix-multiplication"
path = "examples/mps/matrix-multiplication/main.rs"
required-features = ["mps"]

[[example]]
name = "custom-kernels"
path = "examples/mps/custom-kernels/main.rs"
required-features = ["mps"]

[[example]]
name = "mps-ray-intersection"
path = "examples/mps/ray-intersection/main.rs"
required-features = ["mps"]

[[example]]
Expand Down
Loading
Loading