Add gpu_start_time and gpu_end_time to CommandBuffer
#329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Sep 26, 2024
| @@ -66,6 +66,14 @@ impl CommandBufferRef { | |||
| } | |||
| } | |||
|
|
|||
| pub fn gpu_start_time(&self) -> f64 { | |||
There was a problem hiding this comment.
code is good, but could we not put it right between label() and set_label()? I'd suggest putting it right after pop_debug_group() instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bindings for
GPUStartTimeandGPUEndTime.They allow you to determine how much time the GPU spent executing a command buffer.