[glsl-in] Implement swizzle for r-values #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unneccessary Otion in return type
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
kvark
reviewed
Sep 24, 2020
src/front/glsl/variables.rs
Outdated
| meta: TokenMetadata, | ||
| ) -> Result<Handle<Expression>, ErrorKind> { | ||
| let type_inner = self.resolve_type(expression)?; | ||
| match type_inner { |
There was a problem hiding this comment.
let's match on the value always, i.e. match *self.resolve_type(expression)? {..}
There was a problem hiding this comment.
Done, except borrow checker wouldn't let me deref with * (something about unable to move out of shared ref), so had to settle for match self.resolve_type(expression)? {..}
There was a problem hiding this comment.
The whole point of borrowing by value is that it lets you see which things are borrowed, and which not.
So, you see that the borrow checker complains about members field being moved out? Mark it as ref members.
There was a problem hiding this comment.
Ahhh, maybe one day I will learn to actually listen to what the borrow checker tells me :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #210