Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a new version of rspirv #143

Closed
Tracked by #2
Jasper-Bekkers opened this issue Aug 7, 2020 · 9 comments
Closed
Tracked by #2

Publish a new version of rspirv #143

Jasper-Bekkers opened this issue Aug 7, 2020 · 9 comments

Comments

@Jasper-Bekkers
Copy link
Collaborator

Now that SPIR-V 1.5 has been in mainline for a while, we should probably publish a new version of this crate.

@kvark
Copy link
Member

kvark commented Aug 7, 2020

Just make sure to triage the issues that could have impacted the API, to see if they need to be solved before publishing

@Jasper-Bekkers
Copy link
Collaborator Author

I can take a look at #131 and #121, but I think neither should be show stoppers for a release.

@Jasper-Bekkers
Copy link
Collaborator Author

Do we need @antiagainst to push a new version or can you do it @kvark ?

@antiagainst
Copy link
Collaborator

Thanks @Jasper-Bekkers and @kvark for taking of the issues! Unfortuantely I won't have the bandwidth to come back to this. I've invited @kvark on crates.io so he should be able to publish new versions now. :)

@kvark
Copy link
Member

kvark commented Aug 9, 2020

@antiagainst thank you!
I'm fine publishing spirv_headers, but I'm not feeling positive about publishing rspirv itself, since we aren't using it anywhere. Perhaps, it would make sense to share the publishing joy of it with @Jasper-Bekkers ?

@Jasper-Bekkers
Copy link
Collaborator Author

@kvark fwiw, we've been using latest on a few internal projects both at Traverse Research and Embark Studios now.

@Jasper-Bekkers
Copy link
Collaborator Author

#131 and #121 got fixed, can we publish a new version? :-)

This is also holding back publishing a version of https://github.com/Traverse-Research/rspirv-reflect

@kvark
Copy link
Member

kvark commented Aug 21, 2020

Invitations to crates owning are set out to @Jasper-Bekkers

@Jasper-Bekkers
Copy link
Collaborator Author

Thanks, spirv_headers and rspirv got a new version published now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants