Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ZeroOrMore take Iterator instead of AsRef<[T]> #149

Merged
merged 2 commits into from
Aug 22, 2020

Conversation

khyperia
Copy link
Collaborator

This is useful if the user has an iterator instead of a slice/vec, it
saves an allocation.

I think this is a breaking change due to ref differences, not sure if we're okay with that.

(For review, the only file changed is dr.rs, the rest are generated)

This is useful if the user has an iterator instead of a slice/vec, it
saves an allocation.
@Jasper-Bekkers
Copy link
Collaborator

I don't quite know what we rspirv typically does with breaking changes - nor do I know if the change from AsRef<[T]> to IntoIterator is a breaking change.

However, I'm inclined to accept it because this crate is already a bit on the alloc-heavy side of things, so getting that down would be quite nice.

@kvark
Copy link
Member

kvark commented Aug 16, 2020

Looks like a breaking change to me, given that AsRef<[T]> would be implemented for &[T] but IntoIterator<T> wouldn't.

@Jasper-Bekkers
Copy link
Collaborator

Might be good to merge this in after #143

@Jasper-Bekkers Jasper-Bekkers merged commit 16265b8 into master Aug 22, 2020
@khyperia khyperia deleted the less-allocations branch August 24, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants