This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
Update for wgpu-core #291
Merged
Update for wgpu-core #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
force-pushed
the
trace
branch
2 times, most recently
from
89331a4
to
95de390
Compare
grovesNL
approved these changes
May 2, 2020
| // To see the output, run `RUST_LOG=info cargo run --example hello-compute`. | ||
| log::info!("Times: {:?}", execute_gpu(numbers).await); | ||
| let times = execute_gpu(numbers).await; | ||
| println!("Times: {:?}", times); |
There was a problem hiding this comment.
IMO it's slightly distracting to special-case wasm with cfg here – I'd prefer to force the log level in main or pass a logging function to run if we want to ensure it's displayed by default
There was a problem hiding this comment.
ok, sure. I just got confused by the lack of output when running it
kejor
pushed a commit
to kejor/wgpu-rs
that referenced
this pull request
Nov 28, 2020
291: Fix sample_mask field r=kvark a=rukai Looks like it was just missed in gfx-rs/wgpu#285 Co-authored-by: Rukai <rubickent@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on gfx-rs/wgpu#619
Closes #285