Skip to content

Commit

Permalink
Someday I'll stop pushing commits to this damn PR
Browse files Browse the repository at this point in the history
  • Loading branch information
cwfitzgerald committed Mar 21, 2023
1 parent e948314 commit 00e795d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ By @cwfitzgerald in [#3610](https://github.com/gfx-rs/wgpu/pull/3610).
- Improve attachment related errors. By @cwfitzgerald in [#3549](https://github.com/gfx-rs/wgpu/pull/3549)
- Make error descriptions all upper case. By @cwfitzgerald in [#3549](https://github.com/gfx-rs/wgpu/pull/3549)
- Don't include ANSI terminal color escape sequences in shader module validation error messages. By @jimblandy in [#3591](https://github.com/gfx-rs/wgpu/pull/3591)
- Bring anisotropic filtering in line with the spec.

#### WebGPU

Expand Down
5 changes: 1 addition & 4 deletions wgpu-hal/src/vulkan/adapter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -345,10 +345,7 @@ impl PhysicalDeviceFeatures {
caps.supports_extension(vk::KhrSwapchainMutableFormatFn::name()),
);
dl_flags.set(Df::CUBE_ARRAY_TEXTURES, self.core.image_cube_array != 0);
dl_flags.set(
Df::ANISOTROPIC_FILTERING,
self.core.sampler_anisotropy >= 16,
);
dl_flags.set(Df::ANISOTROPIC_FILTERING, self.core.sampler_anisotropy != 0);
dl_flags.set(
Df::FRAGMENT_WRITABLE_STORAGE,
self.core.fragment_stores_and_atomics != 0,
Expand Down
4 changes: 2 additions & 2 deletions wgpu-hal/src/vulkan/device.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1121,8 +1121,8 @@ impl crate::Device<super::Api> for super::Device {
}

if desc.anisotropy_clamp != 1 {
// We only enable the downlevel flag if supports 16x anisotropy,
// and wgpu-hal interface guarentees the clamp is in the range [1, 16]
// We only enable anisotropy if it is supported, and wgpu-hal interface guarentees
// the clamp is in the range [1, 16] which is always supported if anisotropy is.
vk_info = vk_info
.anisotropy_enable(true)
.max_anisotropy(desc.anisotropy_clamp as f32);
Expand Down

0 comments on commit 00e795d

Please sign in to comment.