Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerPreference::Default description no longer applies #943

Closed
lberrymage opened this issue Sep 26, 2020 · 1 comment
Closed

PowerPreference::Default description no longer applies #943

lberrymage opened this issue Sep 26, 2020 · 1 comment
Labels
area: api Issues related to API surface help required We need community help to make this happen. type: bug Something isn't working

Comments

@lberrymage
Copy link
Contributor

Description
The doc comment for PowerPreference::Default is as follows:

/// Prefer low power when on battery, high performance when on mains.

This statement is no longer true since #864 was merged.

Expected vs observed behavior
If a user's device has both a discrete and an integrated GPU and is plugged in, any application they run with PowerPreference::Default will use the integrated GPU, which is behavior contrary to the docs.

It is expected that either

  1. PowerPreference::Default documents its equivalent behavior to PowerPreference::LowPower
  2. PowerPreference::Default doesn't exist to prevent confusion

although I don't know if the second option is feasible or reasonable according to the WebGPU spec.
@kvark kvark added area: api Issues related to API surface type: bug Something isn't working help required We need community help to make this happen. labels Sep 28, 2020
@grovesNL
Copy link
Collaborator

grovesNL commented Nov 6, 2020

Fixed by #973 (Default doesn't exist anymore)

@grovesNL grovesNL closed this as completed Nov 6, 2020
Patryk27 pushed a commit to Patryk27/wgpu that referenced this issue Nov 23, 2022
@JCapucho
[glsl-in] Add integration tests to CI (gfx-rs#943)
87748a2 
* [glsl-in] Add glsl snapshots folder

* [glsl-in] Fix incorrect angle brackets parsing

* [glsl-in] Temporarily remove wgsl snapshot output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api Issues related to API surface help required We need community help to make this happen. type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kvark @grovesNL @lberrymage