Add support for raw vulkan types #1415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
May 30, 2021
| @@ -582,6 +582,9 @@ impl<'a, B: GfxBackend> RenderPassInfo<'a, B> { | |||
| TextureViewInner::SwapChain { .. } => { | |||
| return Err(RenderPassErrorInner::SwapChainImageAsDepthStencil); | |||
| } | |||
| TextureViewInner::Raw { .. } => { | |||
| return Err(RenderPassErrorInner::SwapChainImageAsDepthStencil); | |||
| @@ -496,7 +496,7 @@ fn check_device_features( | |||
| } | |||
|
|
|||
| struct RenderAttachment<'a> { | |||
| texture_id: &'a Stored<id::TextureId>, | |||
| texture_id: Option<&'a Stored<id::TextureId>>, | |||
| @@ -2626,6 +2632,66 @@ impl<B: GfxBackend> Device<B> { | |||
| } | |||
| } | |||
|
|
|||
| impl Device<crate::backend::Vulkan> { | |||
| unsafe fn create_raw_vulkan_texture_view( | |||
There was a problem hiding this comment.
This is quite tricky. How do you feel about the approach in gfx-rs/gfx#3761 as an alternative?
There was a problem hiding this comment.
Recap from discussion we've had on this on Matrix:
The plan right now is to introduce external textures to gfx-rs and use that instead of the raw vulkan views, and see if that's possible with OpenXR.
|
Heads up - we have major re-organization happening, so it would be better to land this after https://github.com/gfx-rs/wgpu/milestone/9 |
|
Sounds good, I'll likely re-write this using some more context when that's all landed. |
|
This seems to have been superseded by #1609 so I'll close this |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
This PR depends on: gfx-rs/gfx#3767
This PR is necessary for: #602
Description
This adds support for using raw Vulkan instances, devices, and images with WGPU. This allows applications to use OpenXR with WGPU.
Testing
Bindings and example in WGPU-RS PR: gfx-rs/wgpu-rs#919
To-Do