Fix failing test compilation on windows - DX12 and DX11 not there. #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectronicRU
force-pushed
the
windows_bug
branch
from
87b31a8
to
8d13d97
Compare
|
@ElectronicRU Could you agree with project relicense #1473 ? |
|
@kvark Yeah, but only after. We still accept patches under MPL-2.0 License 😄 |
|
I mean, after #1473 was filed. I don't know how it all works, but that was the workflow we did for gfx, IIRC. |
Patryk27
pushed a commit
to Patryk27/wgpu
that referenced
this pull request
Nov 23, 2022
Pointers should not be `DATA`: they can never be stored in anything. (Function arguments are not storage; they're like `let` bindings.) Un-`SIZED` values may only live in the `Storage` storage class, so creating pointers to them in other storage classes is meaningless. The `ARGUMENT` flag should be set only on pointers in those storage classes that are permitted to be passed to functions. See comments in code for details. Fixes gfx-rs#1513.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to some things in macros being left on cfg(windows) and some changed to cfg(dx12/dx11), the tests didn't even compile, much less run.
Testing
Ideally, some CI for Windows should be set up.