web: add empty device_create_shader_module_spirv
#1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bors bot
added a commit
that referenced
this pull request
Jun 21, 2021
1534: web: Restore WebGPU CI r=kvark a=grovesNL **Connections** Depends on/currently includes #1533 **Description** Even though the WebGL backend needs to be temporarily disabled, we should be able to continue checking WebGPU on wasm. **Testing** Manually ran the CI command `cargo check --package wgpu --examples --target=wasm32-unknown-unknown` locally which seems to catch the mistake in #1533 without building wgpu-core/wgpu-hal. Co-authored-by: grovesNL <josh@joshgroves.com>
Patryk27
pushed a commit
to Patryk27/wgpu
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added a SPIR-V passthrough function to the
Contexttrait shared between web/native backends, but the web backend also needs an implementation of this function to fully implement the trait.Testing
Compiling the web backend for WebGPU.