Fix Limits for lava/llvmpipe and re-enable and re-work CI #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
re-enable-ci
branch
2 times, most recently
from
6494188
to
a8cfd40
Compare
|
CI is still mad at me, but the code should be otherwise good to look at. |
grovesNL
reviewed
Jul 4, 2021
kvark
approved these changes
Jul 4, 2021
cwfitzgerald
force-pushed
the
re-enable-ci
branch
9 times, most recently
from
8d48e72
to
ab41b5f
Compare
|
Alright, all reviews addressed, CI is passing, lets goo! bors r=kvark,groves,wumpf |
bors bot
added a commit
that referenced
this pull request
Jul 4, 2021
1599: Fix Limits for lava/llvmpipe and re-enable and re-work CI r=kvark,groves,wumpf a=cwfitzgerald **Connections** No longer fixes #1551. **Description** This PR has a couple things going on at once. - Fixes limits for llvmpipe, lavapipe, and rpi4. - Added a downlevel limit to express that RPI4 does not allow storage buffers in vertex shaders on GL. - Added a `Limits::downlevel_default()` that takes minimum limits from GLES and adds some more documentation on how to choose limits. - Moved all examples to the new downlevel limits - Reworks CI to re-enable software testing and unify instructions. **Testing** It is Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
|
bors r- github's UI lied to me and said all 8 passed when only 2 did. |
|
Canceled. |
cwfitzgerald
force-pushed
the
re-enable-ci
branch
from
ab41b5f
to
9ee9b75
Compare
|
bors r=kvark,groves,wumpf |
bors bot
added a commit
that referenced
this pull request
Jul 4, 2021
1599: Fix Limits for lava/llvmpipe and re-enable and re-work CI r=kvark,groves,wumpf a=cwfitzgerald **Connections** No longer fixes #1551. **Description** This PR has a couple things going on at once. - Fixes limits for llvmpipe, lavapipe, and rpi4. - Added a downlevel limit to express that RPI4 does not allow storage buffers in vertex shaders on GL. - Added a `Limits::downlevel_default()` that takes minimum limits from GLES and adds some more documentation on how to choose limits. - Moved all examples to the new downlevel limits - Reworks CI to re-enable software testing and unify instructions. **Testing** It is Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
cwfitzgerald
force-pushed
the
re-enable-ci
branch
from
9ee9b75
to
130ddcf
Compare
|
Canceled. |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
No longer fixes #1551.
Description
This PR has a couple things going on at once.
Limits::downlevel_default()that takes minimum limits from GLES and adds some more documentation on how to choose limits.Testing
It is