Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing SPIRV capability #1911

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Add missing SPIRV capability #1911

merged 1 commit into from
Sep 7, 2021

Conversation

Neo-Zhixing
Copy link
Contributor

@Neo-Zhixing Neo-Zhixing commented Sep 6, 2021 •
edited
Loading

Connections
This is associated with gfx-rs/naga@1c2026b

Description
Due to changes in naga, running bevy's 3d_scene_pipelined example with wgpu HEAD will trigger the following error:

Sep 05 23:39:52.543 ERROR wgpu_core::device: Shader error: using sampled cube array images requires at least one of the capabilities [SampledCubeArray], but none are available
Sep 05 23:39:52.544 ERROR wgpu::backend::direct: wgpu error: Validation Error

Testing
After adding this SPIRV feature, bevy's 3d_scene_pipelined example works as expected.

@Neo-Zhixing Neo-Zhixing mentioned this pull request Sep 6, 2021
Closed
1 task
kvark
kvark approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kvark kvark added the PR: needs back-porting PR with a fix that needs to land on crates label Sep 7, 2021
@kvark kvark enabled auto-merge (squash) September 7, 2021 01:09
@kvark kvark merged commit 66979eb into gfx-rs:master Sep 7, 2021
@Neo-Zhixing Neo-Zhixing deleted the fix/missing-spirv-cap branch September 7, 2021 02:10
kvark pushed a commit to kvark/wgpu that referenced this pull request Sep 8, 2021
@Neo-Zhixing @kvark
add missing capability (gfx-rs#1911)
d9dd87f
@kvark kvark mentioned this pull request Sep 8, 2021
Merged
kvark pushed a commit that referenced this pull request Sep 8, 2021
@Neo-Zhixing @kvark
add missing capability (#1911)
70fad1a
@kvark
Copy link
Member

kvark commented Sep 8, 2021

published in wgpu-hal-0.10.4

@kvark kvark removed the PR: needs back-porting PR with a fix that needs to land on crates label Sep 8, 2021
cwfitzgerald pushed a commit that referenced this pull request Oct 25, 2023
@fornwall
[wgsl-in] Handle all(bool) and any(bool) (#2445)
3bd2834 
Fixes #1911.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Neo-Zhixing @kvark