Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shadow example runnable on iOS Android devices #2433

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Make shadow example runnable on iOS Android devices #2433

merged 1 commit into from
Feb 1, 2022

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Jan 29, 2022

Description
On iOS and Android devices, the min_uniform_buffer_offset_alignment is equal 64 less than the EntityUniforms size, running on these devices failed at assert!(entity_uniform_size <= uniform_alignment):

thread '<unnamed>' panicked at 'assertion failed: entity_uniform_size <= uniform_alignment', src/examples/shadow.rs:289:9

Testing
Tested on macOS, iPhone 12 Pro (iOS 15.3) and Honor V20 (Android 10.0)

IMG_0998 Screenshot_20220129_185831

kvark
kvark previously requested changes Jan 29, 2022
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this!

wgpu/examples/shadow/main.rs Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald dismissed kvark’s stale review February 1, 2022 23:08

Stale, fixed as requested

@cwfitzgerald cwfitzgerald merged commit b10f7ed into gfx-rs:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants