Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct program output ("Steps", not "Times") #2535

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Correct program output ("Steps", not "Times") #2535

merged 1 commit into from
Mar 12, 2022

Conversation

skierpage
Copy link
Contributor

Since 985c1fe , hello-compute has output "Steps: ...", not "Times: ..."

Description
The README doesn't match the current example code's behavior.

Testing
I ran the command from the README

RUST_LOG=hello_compute cargo run --example hello-compute 1 4 3 295

and console output was

Steps: [0, 2, 7, 55]

I didn't see timestamp and INFO prepended to the output, that looks like Rust is logging to the journal or is configured differently.

I don't know if it's worth mentioning

When run in a browser, you have to enable Firefox's Web Developer Tools and enable "Logs" level output in its Console tab to see the output.

Since 985c1fe , hello-compute has output "Steps: ...", not "Times: ..."
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! As for timing, if we don't have a timestamp query implementation for your platform yet (basically only vulkan), we won't show times.

@cwfitzgerald cwfitzgerald merged commit c314c55 into gfx-rs:master Mar 12, 2022
cwfitzgerald pushed a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants