Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metal: Don't skip incomplete binding resources. #2622

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

dragostis
Copy link
Contributor

The old way of generating buffer size updates would only produce updates when all bindings were used by the entry point. If one happened to be missing in only one entry point, the updates wouldn't happen.

The old way of generating buffer size updates would only produce
updates when all bindings were used by the entry point. If one
happened to be missing in only one entry point, the updates
wouldn't happen.
wgpu-hal/src/metal/command.rs Outdated Show resolved Hide resolved
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) April 21, 2022 19:38
@cwfitzgerald cwfitzgerald merged commit 59d640a into gfx-rs:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants