Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHADER_FLOAT16 feature #2646

Merged
merged 2 commits into from
May 13, 2022
Merged

Add SHADER_FLOAT16 feature #2646

merged 2 commits into from
May 13, 2022

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented May 7, 2022

Connections
WebGPU spec
#4384

Description
Dx12 need to check D3D12_FEATURE_DATA_D3D12_OPTIONS4::Native16BitShaderOpsSupported and D3D_SHADER_MODEL_6_2 to comform whether supports true FP16 which winapi currently don't defined, maybe one more reason to replace winapi with windows-rs?

Testing
Tested on metal and vk backend.

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one small thing to fix here

wgpu-hal/src/vulkan/adapter.rs Outdated Show resolved Hide resolved
wgpu-hal/src/vulkan/adapter.rs Outdated Show resolved Hide resolved
wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
@kvark kvark merged commit ddf1903 into gfx-rs:master May 13, 2022
@jinleili jinleili deleted the shader-f16 branch May 13, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants