Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross-references to each wgpu type's documentation. #2653

Merged
merged 2 commits into from
May 13, 2022

Conversation

kpreid
Copy link
Contributor

@kpreid kpreid commented May 13, 2022

Description

Added:

  • WebGPU specification links.
  • How to create an instance, if it is not all-public-fields.
  • What function or enclosing type this type is used for.

(The latter two are not present for wgpu-types items due to the dependency running the wrong direction for that — I saw existing ../wgpu/ links, but those do not work on https://docs.rs/wgpu/.)

This commit specifically does not:

  • substantially revise existing language, except where necessary to fit the new information
  • add similar information to the documentation of types not directly corresponding to the WebGPU specification

Testing

I ran cargo doc, saw no broken intra-doc link warnings, and inspected each type's page for correct appearance.

Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for doing this! Some of the links seem to be wrong; see below. If you could fix these and re-submit, that would be great.

wgpu/src/lib.rs Outdated Show resolved Hide resolved
Added:
* WebGPU specification links.
* How to create an instance, if it is not all-public-fields.
* What function or enclosing type this type is used for.

(The latter two are not present for `wgpu-types` items due to the
dependency running the wrong direction for that — I saw existing
`../wgpu/` links, but those do not work on https://docs.rs/wgpu/.)

This commit specifically does not:
* substantially revise existing language, except where necessary to fit
  the new information, or when there was an obvious trivial improvement
  like adding a link to support "how to use this".
* add similar information to the documentation of types not directly
  corresponding to the WebGPU specification
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. I fixed two more minor things.

@jimblandy jimblandy merged commit 144e943 into gfx-rs:master May 13, 2022
@kpreid kpreid deleted the typespec branch May 13, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants