Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept both parking-lot 0.11 and 0.12, to avoid windows-rs. #2660

Merged
merged 1 commit into from
May 16, 2022
Merged

Accept both parking-lot 0.11 and 0.12, to avoid windows-rs. #2660

merged 1 commit into from
May 16, 2022

Conversation

jimblandy
Copy link
Member

In parking_lot 0.12 and parking_lot_core 0.9.0, those crates switched from the winapi crate to the official Microsoft windows-sys crate. This is fine, except that windows-sys and its dependencies are even larger than winapi. Some users may wish to stick with winapi for the time being; this change allows wgpu to accommodate them.

@jimblandy jimblandy added the area: infrastructure Testing, building, coordinating issues label May 15, 2022
@jimblandy
Copy link
Member Author

Firefox is trying to put off taking the windows crate plunge, so this is needed to allow us to update wgpu without local changes.

cwfitzgerald
cwfitzgerald requested changes May 15, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note, but otherwise lgtm. We should also have a discussion about the timing about when we should take the windows-rs plunge as it is inevitable, but obviously stakeholders have opinions outside of our immediate needs.

wgpu-core/Cargo.toml Outdated Show resolved Hide resolved
@jimblandy jimblandy force-pushed the accept-parking-lot-11 branch from c8436a6 to de7cd72 Compare May 16, 2022 00:27
@jimblandy jimblandy requested a review from cwfitzgerald May 16, 2022 00:27
cwfitzgerald
cwfitzgerald requested changes May 16, 2022
View reviewed changes
wgpu/Cargo.toml Outdated Show resolved Hide resolved
@jimblandy
Accept both parking-lot 0.11 and 0.12.*, to avoid windows-rs.
6d90a66 
In parking_lot 0.12 and parking_lot_core 0.9.0, those crates switched
from the winapi crate to the official Microsoft windows-sys crate.
This is fine, except that windows-sys and its dependencies are even
larger than winapi. Some users may wish to stick with winapi for the
time being; this change allows wgpu to accommodate them.
@jimblandy jimblandy force-pushed the accept-parking-lot-11 branch from de7cd72 to 6d90a66 Compare May 16, 2022 04:16
@jimblandy jimblandy requested a review from cwfitzgerald May 16, 2022 04:17
cwfitzgerald
cwfitzgerald approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Party

@cwfitzgerald cwfitzgerald merged commit c608ee0 into gfx-rs:master May 16, 2022
@jimblandy jimblandy deleted the accept-parking-lot-11 branch May 22, 2022 16:01
@grovesNL grovesNL mentioned this pull request Apr 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
area: infrastructure Testing, building, coordinating issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimblandy @cwfitzgerald