Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEPTH32FLOAT_STENCIL8 featue #2664

Merged
merged 1 commit into from
May 17, 2022
Merged

Add DEPTH32FLOAT_STENCIL8 featue #2664

merged 1 commit into from
May 17, 2022

Conversation

jinleili
Copy link
Contributor

WebGPU spec: https://gpuweb.github.io/gpuweb/#depth32float-stencil8

Testing
Modified skybox locally and tested on metal, vulkan(--features=vulkan-portability) and dx12 backends:

const DEPTH_FORMAT = wgpu::TextureFormat::Depth32FloatStencil8;
fn required_features() -> wgpu::Features {
    wgpu::Features::DEPTH32FLOAT_STENCIL8
}

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise lgtm.

wgpu/tests/clear_texture.rs Outdated Show resolved Hide resolved
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald cwfitzgerald merged commit 26f96c7 into gfx-rs:master May 17, 2022
@teoxoy teoxoy mentioned this pull request Nov 9, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants