Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve InvalidScissorRect error message #2713

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Jun 2, 2022

Connections
#2676

Testing
Calling RenderPass set_scissor_rect with illegal arguments will output the following error message:

thread 'main' panicked at 'wgpu error: Validation Error

Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(0, 1, Metal)>`
    In a set_scissor_rect command
    Scissor Rect { x: 1000, y: 1000, w: 601, h: 200 } is not contained in the render target Extent3d { width: 1600, height: 1200, depth_or_array_layers: 1 }

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much thanks! If you're up to it, I realize the viewport has the same issue.

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) June 2, 2022 07:28
@cwfitzgerald cwfitzgerald merged commit 75db572 into gfx-rs:master Jun 2, 2022
@jinleili
Copy link
Contributor Author

jinleili commented Jun 2, 2022

Okay, I can do that.

@jinleili jinleili deleted the scissor_rect branch June 2, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants