metal: check if in the main thread when calling create_surface
#2736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#2727
Description
On macOS and iOS platforms, calling UI APIs in non-ui thread will cause unexpected results. Tell the user exactly what the problem is by checking if it is in the main thread.
Also tried using Objective-C GCD to specify the main thread to execute the code, but
view: *mut c_void
is not a thread-safe object, and I don't think actively jumping threads is something wgpu should do.Testing
Tested on macOS and iOS.