Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk: fix PIPELINE_STATISTICS_QUERY feature support #2750

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Jun 8, 2022

Description
PIPELINE_STATISTICS_QUERY feature not supported by all vk devices, running mipmap on vk backend on M1 Mac caused error:

[2022-06-08T04:24:38Z ERROR wgpu_hal::vulkan::instance]         objects: (type: INSTANCE, hndl: 0x14d872a00, name: ?)
[mvk-error] VK_ERROR_FEATURE_NOT_PRESENT: vkCreateDevice(): Requested feature is not available on this device.
[2022-06-08T04:24:38Z ERROR wgpu_hal::vulkan::instance] GENERAL | VALIDATION | PERFORMANCE | 1111111111111111111111111111000 [ (0x0)]
        VK_ERROR_FEATURE_NOT_PRESENT: vkCreateDevice(): Requested feature is not available on this device.
[2022-06-08T04:24:38Z ERROR wgpu_hal::vulkan::instance]         objects: (type: DEVICE, hndl: 0x13c02da18, name: ?)
[2022-06-08T04:24:38Z ERROR wgpu_hal::vulkan::instance] GENERAL [Loader Message (0x0)]
        terminator_CreateDevice: Failed in ICD /usr/local/share/vulkan/icd.d/../../../lib/libMoltenVK.dylib vkCreateDevice call
[2022-06-08T04:24:38Z ERROR wgpu_hal::vulkan::instance]         objects: (type: INSTANCE, hndl: 0x14d872a00, name: ?)
[2022-06-08T04:24:38Z ERROR wgpu_hal::vulkan::instance] GENERAL [Loader Message (0x0)]
        vkCreateDevice:  Failed to create device chain.
[2022-06-08T04:24:38Z ERROR wgpu_hal::vulkan::instance]         objects: (type: INSTANCE, hndl: 0x14d872a00, name: ?)
[2022-06-08T04:24:38Z ERROR wgpu::backend::direct] Error in Adapter::request_device: connection to device was lost during initialization

Testing
Tested mipmap example on vk backend.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big whoops

@cwfitzgerald cwfitzgerald merged commit 5e07078 into gfx-rs:master Jun 8, 2022
@jinleili jinleili deleted the pipeline-statistics-query branch June 8, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants