Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve push constant documentation, including internal docs. #2764

Merged
merged 1 commit into from
Jun 11, 2022
Merged

Improve push constant documentation, including internal docs. #2764

merged 1 commit into from
Jun 11, 2022

Conversation

jimblandy
Copy link
Member

No description provided.

@jimblandy jimblandy added the area: documentation Documentation for crate items, public or private label Jun 11, 2022
@jimblandy jimblandy requested a review from cwfitzgerald June 11, 2022 07:00
cwfitzgerald
cwfitzgerald requested changes Jun 11, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with nits

wgpu-core/src/command/bundle.rs Outdated Show resolved Hide resolved
wgpu-core/src/command/compute.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Show resolved Hide resolved
@jimblandy jimblandy force-pushed the push-constant-docs branch from 76a3afc to 7e2e4df Compare June 11, 2022 17:26
@jimblandy jimblandy requested a review from cwfitzgerald June 11, 2022 17:27
cwfitzgerald
cwfitzgerald approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Party on

@cwfitzgerald cwfitzgerald merged commit a4352a1 into gfx-rs:master Jun 11, 2022
@jimblandy jimblandy deleted the push-constant-docs branch June 13, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
area: documentation Documentation for crate items, public or private
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimblandy @cwfitzgerald