wgpu_core::command::bundle: Consolidate pipeline and vertex state. #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
bundle-isolate-vertex-and-pipeline-state
branch
2 times, most recently
from
7d426b7 to
1c74a53
Compare
jimblandy
force-pushed
the
bundle-isolate-vertex-and-pipeline-state
branch
2 times, most recently
from
4f010c6 to
d65fcd7
Compare
Refactor `wgpu_core::command::bundle::State` to more closely resemble the internal slots of a WebGPU `GPURenderBundleEncoder`, and add validation required by the WebGPU specification. Use `Option` to represent state that may be left unset on the encoder: specifically, the pipeline and vertex buffers. (Previous commits have already addressed index buffers and bind groups.) Use `.ok_or`, etc. for unwrapping, to ensure that encoding state errors are reported. Consolidate state derived from the pipeline in a new `PipelineState` struct. Remove `wgpu_core::command::bundle::PushConstantState::is_dirty`; just represent push constant state as a vector of `PushConstantRange` values. It's sufficient to simply zero the push constants whenever the vector is non-empty. Rename `bundle::State::flush_push_constants` to `zero_push_constants`a. This is not a "flush pending state changes" function like all the others; it just ensures that each pipeline's push constant state is initialized.
jimblandy
force-pushed
the
bundle-isolate-vertex-and-pipeline-state
branch
from
d65fcd7 to
e3573d2
Compare
|
I hope this isn't too much stuff jammed into one PR. I think the easiest way to see what's going on is to look at the new definition of |
cwfitzgerald
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
wgpu_core::command::bundle::Stateto more closely resemble the internal slots of a WebGPUGPURenderBundleEncoder, and add validation required by the WebGPU specification.Use
Optionto represent state that may be left unset on the encoder: specifically, the pipeline and vertex buffers. (Previous commits have already addressed index buffers and bind groups.) Use.ok_or, etc. for unwrapping, to ensure that encoding state errors are reported.Consolidate state derived from the pipeline in a new
PipelineStatestruct.Remove
wgpu_core::command::bundle::PushConstantState::is_dirty; just represent push constant state as a vector ofPushConstantRangevalues. It's sufficient to simply zero the push constants whenever the vector is non-empty.Rename
bundle::State::flush_push_constantstozero_push_constants. This is not a "flush pending state changes" function like all the others; it just ensures that each pipeline's push constant state is initialized.