Add back get_preferred_format and sRGB preference #2785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Jun 18, 2022
| /// | ||
| /// Returns None if the surface is incompatible with the adapter. | ||
| pub fn get_supported_formats(&self, adapter: &Adapter) -> Option<Vec<TextureFormat>> { | ||
| Context::surface_get_supported_formats(&*self.context, &self.id, &adapter.id) | ||
| } | ||
|
|
||
| /// Returns an optimal texture format to use for the [`Surface`] with this adapter. | ||
| pub fn get_preferred_format(&self, adapter: &Adapter) -> Option<wgt::TextureFormat> { |
There was a problem hiding this comment.
Instead of doing this separately, both methods of "preferred" format should return the same value. How about inside of get_supported_formats we just bring the srgb formats to the front - caps.format.sort_by_key(|f| !f.describe().srgb . Once we support texture view changing srgb-ness we can remove the sort.
| @@ -269,11 +269,7 @@ fn start<E: Example>( | |||
| let spawner = Spawner::new(); | |||
| let mut config = wgpu::SurfaceConfiguration { | |||
| usage: wgpu::TextureUsages::RENDER_ATTACHMENT, | |||
| format: *surface | |||
There was a problem hiding this comment.
I'm not sold on needing a separate api here - especially if we remove the outer option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Partially reverts the changes in #2783 .
Description
Adds back the get_preferred_format function, to avoid breaking people's code and get back the preference for sRGB.
Testing
Ran some examples.