Replace android-properties with android_system_properties. #2815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2805.
Description
android-properties
use statically linked Android libc symbols whileandroid_system_properties
loads them dynamically. This is required to support old and new versions of Android with the same binary. It unblocks updating wgpu in Gecko.In its current version,
android_system_properties
supports exactly what wgpu needs and nothing more, which makes it easy to audit, don't hesitate to give it a critical look: https://github.com/nical/android_system_properties/blob/00c55a5a871e3fc6d9b133f96bf6d74c8e1927cf/src/lib.rs and report concerns here or in an issue on the repo.I heared back from the
android-properties
crate author yet in my PR their repo and I can't afford to wait for too long as this blocks a lot of work on the Firefox side. So I ended up putting together an alternative crate (the PR was already pretty much an entire rewrite). I'll be happy to move wgpu back toandroid_properties
if/when things can be resolved there (and yank the wholeandroid_system_properties
crate.Testing
I tested it manually on a device, however it is a bit hard to automate. This doesn't change the test coverage as far as wgpu is concerned.