-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update present_mode docs as most of them don't automatically fall back to Fifo anymore. #2855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment
Auto(No)Vsync fallback wording. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add it to the changelog under documentation and we're good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…k to Fifo anymore. (gfx-rs#2855) * space PresentMode no longer automatically falls back to Fifo * Update wgpu-types/src/lib.rs Auto(No)Vsync fallback wording. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com> * changelog Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
…k to Fifo anymore. (#2855) * space PresentMode no longer automatically falls back to Fifo * Update wgpu-types/src/lib.rs Auto(No)Vsync fallback wording. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com> * changelog Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Description
PresentMode docs on the SurfaceConfiguration struct were outdated due to #2803, so I updated them. I also added Wayland as a common platform that Immediate mode doesn't work on.