expose context and display from adapter and device for egl gles hal #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
changed the title
i509VCB
force-pushed
the
egl-adapter-context
branch
from
823c40f to
0b57522
Compare
i509VCB
force-pushed
the
egl-adapter-context
branch
from
0b57522 to
c6edc9c
Compare
cwfitzgerald
approved these changes
Jul 10, 2022
cwfitzgerald
pushed a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Jul 14, 2022
cwfitzgerald
pushed a commit
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Description
For extensions to wgpu to be able to interface with EGL, the EGLDisplay, EGLContext and version of EGL need to be available from the adapter and device in the gles hal.
This means the existing
AdapterContext::raw_contextfunction is now exposed without needing renderdoc to be enabled.This function also provides access to
get_proc_addressvia exposingEGLInstance.