Add Buffer::size() and Buffer::usage().
#2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://gpuweb.github.io/gpuweb/#buffer-interface Implementation note: it would save 8 bytes of memory to ask the backend for the size, instead of storing it separately, since many backends have the size stored anyway. But, that seemed like it would overcomplicate the architecture for tiny memory savings, and `usage` is already stored in the `wgpu::Buffer` anyway (though only used once, prior to now).
cwfitzgerald
requested changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Fixes #2904
Description
Implements
sizeandusagefrom https://gpuweb.github.io/gpuweb/#buffer-interfaceTesting
Added a unit test and ran the test suite. Since this does not interact with the backend at all, there should be no platform-specific testing needed.