Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid overflow in check texture copy bounds. #2963

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Avoid overflow in check texture copy bounds. #2963

merged 1 commit into from
Aug 29, 2022

Conversation

jimblandy
Copy link
Member

@jimblandy jimblandy commented Aug 14, 2022 •
edited
Loading

Fixes #2962. Includes new tests.

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@jimblandy jimblandy force-pushed the texture-copy-bounds-overflow branch from e4df8cf to 61d151e Compare August 14, 2022 07:31
@jimblandy jimblandy requested a review from cwfitzgerald August 17, 2022 23:58
cwfitzgerald
cwfitzgerald approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love me some testing

@cwfitzgerald cwfitzgerald merged commit 7d138e2 into gfx-rs:master Aug 29, 2022
@jimblandy jimblandy deleted the texture-copy-bounds-overflow branch September 23, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unhandled overflow in validate_texture_copy_range
2 participants
@jimblandy @cwfitzgerald