Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wasm32 dependencies, set alpha_mode on web target #3040

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Update wasm32 dependencies, set alpha_mode on web target #3040

merged 2 commits into from
Sep 20, 2022

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Sep 20, 2022 •
edited
Loading

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
#2836

Testing
Tested locally via cargo run-wasm --example XXX

cwfitzgerald
cwfitzgerald approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just update the wiki wasm-bindgen version?

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) September 20, 2022 04:14
auto-merge was automatically disabled September 20, 2022 04:22

Head branch was pushed to by a user without write access

@jinleili
Copy link
Contributor Author

Could you just update the wiki wasm-bindgen version?

No problem，updated.

@jinleili
Copy link
Contributor Author

Weird iOS check failed

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) September 20, 2022 06:49
@cwfitzgerald cwfitzgerald merged commit ffd7337 into gfx-rs:master Sep 20, 2022
@jinleili jinleili deleted the web-sys branch September 20, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinleili @cwfitzgerald