Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a command encoder is dropped, destroy its hal command buffer. #3069

Merged
merged 1 commit into from
Oct 6, 2022
Merged

When a command encoder is dropped, destroy its hal command buffer. #3069

merged 1 commit into from
Oct 6, 2022

Conversation

jimblandy
Copy link
Member

Fixes #2965.

I'm suspicious that it's this simple, but CommandBuffers are not reference-counted, and we have taken ownership of it by calling unregister, just like queue_submit would, so this seems okay. I guess CI will educate me.

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@jimblandy jimblandy added type: bug Something isn't working area: correctness We're behaving incorrectly labels Oct 6, 2022
@jimblandy jimblandy requested a review from cwfitzgerald October 6, 2022 01:07
@jimblandy jimblandy self-assigned this Oct 6, 2022
cwfitzgerald
cwfitzgerald approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If validation isn't mad, dewit

@jimblandy jimblandy merged commit c781971 into gfx-rs:master Oct 6, 2022
jimblandy added a commit to jimblandy/wgpu that referenced this pull request Oct 6, 2022
@jimblandy
Provoke VUID-vkDestroyDevice-device-00378 without gfx-rs#3069.
0ee6600 
This test should have been included in gfx-rs#3069.
@jimblandy jimblandy mentioned this pull request Oct 6, 2022
Merged
3 tasks
jimblandy added a commit to jimblandy/wgpu that referenced this pull request Oct 6, 2022
@jimblandy
Provoke VUID-vkDestroyDevice-device-00378 without gfx-rs#3069.
fddeb91 
This test should have been included in gfx-rs#3069.
cwfitzgerald pushed a commit that referenced this pull request Oct 6, 2022
@jimblandy
Provoke VUID-vkDestroyDevice-device-00378 without #3069. (#3075)
58f92cc
@jimblandy jimblandy deleted the free-dropped-command-buffer branch November 23, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees

@jimblandy jimblandy

Labels
area: correctness We're behaving incorrectly type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulkan validation failure: VUID-vkDestroyDevice-device-00378
2 participants
@jimblandy @cwfitzgerald