Use std::fmt::Formatter::debug_struct for RenderPass.
#3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
approved these changes
Oct 13, 2022
Comment on lines
+239
to
+249
| f.debug_struct("RenderPass") | ||
| .field("encoder_id", &self.parent_id) | ||
| .field("color_targets", &self.color_targets) | ||
| .field("depth_stencil_target", &self.depth_stencil_target) | ||
| .field("command count", &self.base.commands.len()) | ||
| .field("dynamic offset count", &self.base.dynamic_offsets.len()) | ||
| .field( | ||
| "push constant u32 count", | ||
| &self.base.push_constant_data.len(), | ||
| ) | ||
| .finish() |
There was a problem hiding this comment.
thought: Would destructuring before the debug_struct call here be helpful for keeping fields in sync? That way, the compiler can provide warnings when new fields are added, at the least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.