Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for MSAA(x2,x8) beyond WEBGPU restrictions for native a… #3140

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Added support for MSAA(x2,x8) beyond WEBGPU restrictions for native a… #3140

merged 6 commits into from
Nov 9, 2022

Conversation

39ali
Copy link
Contributor

@39ali 39ali commented Oct 26, 2022 •
edited
Loading

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Closes Can't set MSAA samples beyond 4 .

Description
Native adapters can now use MSAA x2 and x8 if it's supported , previously only x1 and x4 were supported .

Testing
Tested locally on chrome canary , macOS(intel) , win10

cwfitzgerald
cwfitzgerald requested changes Oct 26, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR on the whole looks good, but I think there's a cleaner strategy for the flags which will re-arrange things a bit

wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
@39ali
Copy link
Contributor Author

39ali commented Oct 27, 2022

Hi @cwfitzgerald , let me know what you think!

cwfitzgerald
cwfitzgerald requested changes Oct 28, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great stuff, have some comments, mostly around feature querying.

Looking forward to having this in!

wgpu-core/src/device/mod.rs Outdated Show resolved Hide resolved
wgpu-core/src/device/mod.rs Show resolved Hide resolved
wgpu-core/src/device/mod.rs Outdated Show resolved Hide resolved
wgpu-core/src/device/mod.rs Outdated Show resolved Hide resolved
wgpu-core/src/resource.rs Outdated Show resolved Hide resolved
wgpu-hal/src/dx12/adapter.rs Outdated Show resolved Hide resolved
wgpu-hal/src/gles/adapter.rs Outdated Show resolved Hide resolved
wgpu-hal/src/metal/adapter.rs Outdated Show resolved Hide resolved
wgpu/examples/msaa-line/main.rs Show resolved Hide resolved
@39ali
Copy link
Contributor Author

39ali commented Nov 1, 2022

hey @cwfitzgerald, please take a look !.

@39ali 39ali requested a review from cwfitzgerald November 2, 2022 11:23
cwfitzgerald
cwfitzgerald requested changes Nov 2, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close, some small stuff

wgpu-hal/src/metal/adapter.rs Outdated Show resolved Hide resolved
wgpu-hal/src/metal/adapter.rs Outdated Show resolved Hide resolved
wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
@39ali 39ali requested a review from cwfitzgerald November 3, 2022 12:54
cwfitzgerald
cwfitzgerald approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald cwfitzgerald merged commit 3c82a4c into gfx-rs:master Nov 9, 2022
This was referenced Dec 19, 2022
Closed
Closed
@wilk10 wilk10 mentioned this pull request Jan 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't set MSAA samples beyond 4
2 participants
@39ali @cwfitzgerald