Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphicsCommandList validation #3204

Merged
merged 6 commits into from
Jan 4, 2023

Conversation

xiaopengli89
Copy link
Contributor

@xiaopengli89 xiaopengli89 commented Nov 13, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Description
We should not re-use GraphicsCommandList when close or reset fails.

https://learn.microsoft.com/en-us/windows/win32/api/d3d12/nf-d3d12-id3d12graphicscommandlist-reset

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2022

Codecov Report

Merging #3204 (73bb739) into master (f0f700c) will increase coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3204      +/-   ##
==========================================
+ Coverage   65.64%   66.03%   +0.39%     
==========================================
  Files          82       64      -18     
  Lines       39479    34310    -5169     
==========================================
- Hits        25915    22656    -3259     
+ Misses      13564    11654    -1910     
Impacted Files Coverage Δ
wgpu-hal/src/auxil/renderdoc.rs 40.50% <0.00%> (-3.55%) ⬇️
wgpu-hal/src/lib.rs 23.30% <0.00%> (-2.92%) ⬇️
wgpu-hal/src/gles/egl.rs 38.00% <0.00%> (-0.50%) ⬇️
wgpu-types/src/lib.rs 87.64% <0.00%> (-0.48%) ⬇️
wgpu-hal/src/vulkan/instance.rs 37.41% <0.00%> (-0.20%) ⬇️
wgpu/src/lib.rs 51.25% <0.00%> (-0.19%) ⬇️
wgpu-core/src/validation.rs 58.87% <0.00%> (-0.14%) ⬇️
wgpu-core/src/device/mod.rs 66.53% <0.00%> (-0.11%) ⬇️
wgpu-core/src/command/render.rs 61.37% <0.00%> (-0.06%) ⬇️
wgpu-hal/src/dx12/command.rs
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

wgpu-hal/src/dx12/command.rs Outdated Show resolved Hide resolved
wgpu-hal/src/dx12/command.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@nical nical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwfitzgerald
Copy link
Member

We got conflicts but g2g

@xiaopengli89
Copy link
Contributor Author

xiaopengli89 commented Jan 4, 2023

How can I help? Should I rebase onto master branch?

@nical
Copy link
Contributor

nical commented Jan 4, 2023

How can I help? Should I rebase onto master branch?

Yes please.

@xiaopengli89 xiaopengli89 force-pushed the command-list-validation branch from 73bb739 to 783ff3e Compare January 4, 2023 13:07
@xiaopengli89
Copy link
Contributor Author

Conflicts resolved.

@nical
Copy link
Contributor

nical commented Jan 4, 2023

Thanks!

@nical nical merged commit 71f5040 into gfx-rs:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants